Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New schema field - secondary contact list #1388

Merged
merged 13 commits into from
Feb 14, 2025
Merged

New schema field - secondary contact list #1388

merged 13 commits into from
Feb 14, 2025

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Jan 29, 2025

  • update data model
  • add example curation on UniProt
  • add data integrity tests
  • incorporate into contributors summary page
  • generate new schema JSON file
  • show secondary contacts below primary contact on resource page
  • update contribution guide

@cthoyt cthoyt changed the title Add secondary contact list New schema field - secondary contact list Jan 30, 2025
@bgyori
Copy link
Contributor

bgyori commented Feb 7, 2025

@cthoyt is this something you plan to get back to or should @nagutm look into wrapping it up? Just one clarification: what do you mean by incorporation into the "resources page"?

@cthoyt cthoyt marked this pull request as ready for review February 11, 2025 13:26
@cthoyt
Copy link
Member Author

cthoyt commented Feb 11, 2025

error seems to be due to an issue with the pandas intersphinx registry giving a cloudflare HTTP 522 error

@cthoyt cthoyt merged commit 9fa6bdf into main Feb 14, 2025
12 checks passed
@cthoyt cthoyt deleted the update-contact-model branch February 14, 2025 00:10
cthoyt added a commit that referenced this pull request Feb 14, 2025
This PR adds a slot for multiple reviews, for situations like in #1406
where multiple people gave meaningful feedback and decided on accepting
a record

This PR also updates the RDF output to add a few things missed with
recent PRs #1389/#1388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants